Docker demo support #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasserm
reviewed
Apr 11, 2021
Owner
krasserm
left a comment
krasserm
left a comment
There was a problem hiding this comment.
Awesome pull request Ben, thanks a lot for your contribution! I only had two minor comments ...
README.md
Outdated
| ## SRGAN | ||
| ### SRGAN | ||
|
|
||
| ### Generator pre-training |
Owner
There was a problem hiding this comment.
Should start with #### then? Also next section ...
Author
There was a problem hiding this comment.
Shouldn't what? SRGAN? Is it a subset of WDSR (above it) or Pre-trained weights?
Owner
There was a problem hiding this comment.
Sections Generator pre-training and Generator fine-tuning (GAN) are subsections of SRGAN, so when you increase the level of SRGAN from ## to ### the levels of these subsections should be increased from ### to ####.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for trying out super-resolution with Docker.
Also added nvidia-docker support.