fix: reset restmapper instead on invalidating discoveryclient#26
Merged
matteogastaldello merged 1 commit intomainfrom Nov 27, 2025
Merged
Conversation
Contributor
matteogastaldello
commented
Nov 25, 2025
matteogastaldello
commented
- Updated HandlerOptions to use a pointer for Clientset.
- Modified ServeHTTP method to pass Clientset as a pointer to NewCachedClientFromRestConf.
- Adjusted test cases to create Clientset as a pointer.
- Enhanced CachedClients struct to include a mapper.
- Changed StartCRDInformer and related functions to accept pointer types for CachedClients.
- Updated fakeInvalidator to use Reset instead of Invalidate for better clarity.
- Ensured main function passes Clientset as a pointer when starting the CRD informer.
- Updated HandlerOptions to use a pointer for Clientset. - Modified ServeHTTP method to pass Clientset as a pointer to NewCachedClientFromRestConf. - Adjusted test cases to create Clientset as a pointer. - Enhanced CachedClients struct to include a mapper. - Changed StartCRDInformer and related functions to accept pointer types for CachedClients. - Updated fakeInvalidator to use Reset instead of Invalidate for better clarity. - Ensured main function passes Clientset as a pointer when starting the CRD informer.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.