fix: missing username

krauters · Sep 25, 2024 · 5b9508d · 5b9508d
1 parent cdeef1d
commit 5b9508d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -32,5 +32,6 @@ jobs:
           github-token: ${{ secrets.GH_TOKEN_GH_NOTIFIER }}
           channels: C07L8EWB389
           slack-token: ${{ secrets.SLACK_TOKEN_GH_NOTIFIER }}
+          with-test-data: true
       - name: Print Output
         run: echo "${{ steps.test-action.outputs.response }}"
diff --git a/dist/index.js b/dist/index.js
@@ -41955,7 +41955,8 @@ async function getPullBlocks(pull, slack, withUserMentions) {
             email,
             username,
         });
-        const displayName = slackUser?.profile?.display_name;
+        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+        const displayName = slackUser?.profile?.display_name || slackUser?.profile?.real_name_normalized || username;
         const imageUrl = slackUser?.profile?.image_72;
         contextBlocks.push({
             elements: [
@@ -41969,7 +41970,7 @@ async function getPullBlocks(pull, slack, withUserMentions) {
                     type: 'image',
                 },
                 {
-                    text: `*${displayName ?? username}* ${context} _${relativeHumanReadableAge}_.`,
+                    text: `*${displayName}* ${context} _${relativeHumanReadableAge}_.`,
                     type: 'mrkdwn',
                 },
             ],

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/utils/slack/blocks.ts b/src/utils/slack/blocks.ts
@@ -145,7 +145,8 @@ export async function getPullBlocks(pull: Pull, slack: SlackClient, withUserMent
 			username,
 		})
 
-		const displayName = slackUser?.profile?.display_name
+		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+		const displayName = slackUser?.profile?.display_name || slackUser?.profile?.real_name_normalized || username
 		const imageUrl = slackUser?.profile?.image_72
 
 		contextBlocks.push({
@@ -160,7 +161,7 @@ export async function getPullBlocks(pull: Pull, slack: SlackClient, withUserMent
 					type: 'image',
 				},
 				{
-					text: `*${displayName ?? username}* ${context} _${relativeHumanReadableAge}_.`,
+					text: `*${displayName}* ${context} _${relativeHumanReadableAge}_.`,
 					type: 'mrkdwn',
 				},
 			],