Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23 Missing Username #24

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix #23 Missing Username #24

merged 1 commit into from
Sep 25, 2024

Conversation

coltenkrauter
Copy link
Contributor

@coltenkrauter coltenkrauter commented Sep 25, 2024

Description

Fixes #23 – I previously used nullish coalescing to select the username from the Slack user object, but display_name may be an empty string, leading to an empty string being used for username rather than the username fallbacks.

Type of Change

  • New feature
  • Bug fix
  • Chore
  • Configuration
  • Documentation
  • Refactoring
  • Hotfix
  • Security
  • GitFlow

Testing

  • Executed locally
  • Unit tests
  • Integration tests
  • Load tests
  • PR Status checks
  • Workflow execution (against non-default branch)
  • Other (explain)
  • Not worth it (explain)
  • Not applicable

Checklist

[Not required to be completed, just check off what you've done.]

  • Commits are reasonably sized and the commit message describes the changes well.
  • I have made corresponding changes to the documentation.
  • I have added unit tests for changes to business logic.
  • I have emitted metrics so our team can monitor the health of this system related to these changes.
  • I have added logs to ensure debugging is straight-forward when issues arise.
  • I have considered failure modes (e.g. major dependency becomes unavailable, bad data passed in).
  • I have added a comment to this PR to discuss any concerns/risks of these changes. This might include effects on performance, new dependencies, changes in behavior, or difficult things to test.
  • I have considered whether some of these changes should go into a shared package to increase code reusability.

@coltenkrauter coltenkrauter self-assigned this Sep 25, 2024
@coltenkrauter coltenkrauter linked an issue Sep 25, 2024 that may be closed by this pull request
@coltenkrauter coltenkrauter merged commit 7eb9417 into main Sep 25, 2024
4 checks passed
@coltenkrauter coltenkrauter deleted the 23-fix-missing-username branch September 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing username
1 participant