Feature/enable mixed helmholtz discretizations #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, mixed discretizations, at least with the scalar primal and dual functions for Helmholtz-type operators are not working due to wrong hardcoded loop boundaries. This is now fixed by using the number of shape functions.
These can be useful for mixed discretization of Helmholtz3D type of integral equations.
Overall, the observed error is comparable to the standard discretizations. Note, however, that it might be useful (TODO) adding unit tests for individual matrix element assemblies.
sbadrian
force-pushed
the
feature/enable_mixed_Helmholtz_Discretizations
branch
from
a2eadc2
to
b914087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mixed discretizations of Helmholtz-type operators are not working correctly with Sauter-Schwab-Quadrature.
This should fix it. A integration test serves to ensure future validity.
TODO(?): Maybe it is worth to add unit tests on a matrix entry level to ensure correctness of the discretization. The integration test lets me believe that overall, the implementation is sound.