fix: enable OIDC auth for npm trusted publishing#27
Merged
Conversation
- Rename misleading "should handle lookup consistently within tolerance window" to "should return lock info for active lock" - Move Storage Key Consistency tests from E2E to new crypto.test.ts - Add comprehensive unit tests for generateLockId, hashKey, formatFence
Remove registry-url to prevent actions/setup-node from creating token-based .npmrc. Clear any stale npm tokens to ensure OIDC flow is used for provenance signing.
koistya
force-pushed
the
fix/npm-oidc-publish
branch
from
fdf7a01 to
a5c01a7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 42 42
Lines 2688 2688
=======================================
Hits 2053 2053
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
koistya
added a commit
that referenced
this pull request
Dec 2, 2025
koistya
added a commit
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry-urlfromactions/setup-nodeto prevent token-based.npmrccreationNODE_AUTH_TOKENandNPM_TOKENenv vars before publish.npmrcto ensure OIDC flow is usedThis fixes the "Access token expired or revoked" error during npm publish by ensuring the workflow uses OIDC-based authentication instead of the stale token.