Skip to content

fix: useViewportScrollCoords & useViewportScale fall back properly #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: useViewportScrollCoords & useViewportScale fall back properly #269

wants to merge 1 commit into from

Conversation

DougReeder
Copy link

  1. Both hooks fall back properly when window.visualViewport isn't defined (as in jsdom when running tests, or an old browser)
  2. useViewportScale falls back to 1.0 rather than 0
  3. useViewportScrollCoords also updates on resize events resize

@DougReeder
Copy link
Author

I don't know why the Build Errored, but it builds fine and the tests pass for me, using node 14.16.1 under MacOS 11.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougReeder