Conversation
HACS validation requires URLs to use description_placeholders instead of being inline in translation strings.
There was a problem hiding this comment.
Pull request overview
This PR fixes a HACS translation validation error by replacing inline URLs with description placeholders across all 16 translation files and the config flow. The HACS validator requires that translation strings should not contain URLs directly, but instead use placeholders with the actual URL passed via description_placeholders.
Changes:
- Replaced hardcoded URL
https://www.polleninformation.at/en/data-interface/request-an-api-keywith placeholder{api_key_url}in all 16 translation files - Updated
config_flow.pyto pass the API key URL viadescription_placeholdersparameter - Ensures HACS CI validation will pass
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| custom_components/polleninformation/translations/en.json | Replaced inline URL with {api_key_url} placeholder in config step description |
| custom_components/polleninformation/translations/de.json | Replaced inline URL with {api_key_url} placeholder (German translation) |
| custom_components/polleninformation/translations/es.json | Replaced inline URL with {api_key_url} placeholder (Spanish translation) |
| custom_components/polleninformation/translations/fi.json | Replaced inline URL with {api_key_url} placeholder (Finnish translation) |
| custom_components/polleninformation/translations/fr.json | Replaced inline URL with {api_key_url} placeholder (French translation) |
| custom_components/polleninformation/translations/hu.json | Replaced inline URL with {api_key_url} placeholder (Hungarian translation) |
| custom_components/polleninformation/translations/it.json | Replaced inline URL with {api_key_url} placeholder (Italian translation) |
| custom_components/polleninformation/translations/lt.json | Replaced inline URL with {api_key_url} placeholder (Lithuanian translation) |
| custom_components/polleninformation/translations/lv.json | Replaced inline URL with {api_key_url} placeholder (Latvian translation) |
| custom_components/polleninformation/translations/pl.json | Replaced inline URL with {api_key_url} placeholder (Polish translation) |
| custom_components/polleninformation/translations/pt.json | Replaced inline URL with {api_key_url} placeholder (Portuguese translation) |
| custom_components/polleninformation/translations/ru.json | Replaced inline URL with {api_key_url} placeholder (Russian translation) |
| custom_components/polleninformation/translations/sk.json | Replaced inline URL with {api_key_url} placeholder (Slovak translation) |
| custom_components/polleninformation/translations/sv.json | Replaced inline URL with {api_key_url} placeholder (Swedish translation) |
| custom_components/polleninformation/translations/tr.json | Replaced inline URL with {api_key_url} placeholder (Turkish translation) |
| custom_components/polleninformation/translations/uk.json | Replaced inline URL with {api_key_url} placeholder (Ukrainian translation) |
| custom_components/polleninformation/config_flow.py | Added description_placeholders parameter with the API key URL to async_show_form call |
Both config_flow and options_flow now import from const.py instead of hardcoding the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{api_key_url}placeholderdescription_placeholdersinconfig_flow.pyTest plan