feat: Update class safelist for darkmode support #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This safelist is used to generate tailwind classes that cannot be inferred from the code, ie: where
Shard::Colors.variant
andShard::Colors.variants
are used.Having to keep the updated manually is not an ideal solution, but for now it works, I'll be raising a ticket to investigate ways of populating this automatically.
The easiest way to test this locally is to copy the
safelist
array from this PR intodemo/tailwind.config.js
in the main shard repo and then run the demo. At this stage you'll be doing a regression test to ensure I haven't broken any of the existing components 😅Although it should be pretty clear from the diff that this only adds new patterns and doesn't affect any existing ones 👍