Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up after migrating PullToRefresh to Material3 #66

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Clean-up after migrating PullToRefresh to Material3 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion basic-feature/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ dependencies {
implementation(project(":core"))

implementation(platform(libs.compose.bom))
implementation(libs.accompanist.swipe.refresh)
implementation(libs.coil)
implementation(libs.compose.material3)
implementation(libs.hilt)
Expand Down
3 changes: 1 addition & 2 deletions ...e/src/test/java/eu/krzdabrowski/starter/basicfeature/presentation/RocketsViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class RocketsViewModelTest {
}

@Test
fun `should show loading state with no error state first during rockets refresh`() = runTest {
fun `should show loading state with no error state during rockets refresh`() = runTest {
// Given
every { getRocketsUseCase() } returns emptyFlow()
setUpRocketsViewModel()
Expand All @@ -79,7 +79,6 @@ class RocketsViewModelTest {
// Then
objectUnderTest.uiState.test {
val actualItem = awaitItem()
println(actualItem)

assertTrue(actualItem.isLoading)
assertFalse(actualItem.isError)
Expand Down
2 changes: 0 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ ksp = "1.9.22-1.0.16"
ktlint = "3.16.0"

# production libraries
accompanist = "0.32.0"
coil = "2.5.0"
compose-bom = "2023.10.01"
compose-compiler = "1.5.8"
Expand Down Expand Up @@ -51,7 +50,6 @@ ktlint = { id = "org.jmailen.kotlinter", version.re

[libraries]
# production libraries
accompanist-swipe-refresh = { module = "com.google.accompanist:accompanist-swiperefresh", version.ref = "accompanist" }
coil = { module = "io.coil-kt:coil-compose", version.ref = "coil" }
compose-bom = { group = "androidx.compose", name = "compose-bom", version.ref = "compose-bom" }
compose-material3 = { module = "androidx.compose.material3:material3", version.ref = "compose-material3" }
Expand Down