Contracts in actions #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzykamil
changed the title
krzykamil
changed the title
|
hey thanks for working on this! it's looking good and I'm wondering what's missing (if anything) and if you're planning to open a PR? |
@solnic Hey, thanks for checking it out, I completely forgot to transfer the PR to target the main repo :) . I will do it today, after updating the description. Then its just getting a review and working on it if needed I suppose |
|
moved to hanami#451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to define
contractblocks that behave the same as Dry::Validation contract, because they will essentially pass their contents to insides of that gemThere are many details left to do, but the main "pass the block to try validation" seems ok. I am also not sure about making contract available on request inside
handle. It pararels the params, but params are direct wrapper upon the request params so it makes more sense. Contract is more of an abstract thing so attaching it to the request seems "meh" at my first glance