Tuneups #2
Open
Tuneups #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 26, 2017 23:44
- hashTable is just array of buckets now - do not use expensive % operation * Improvements in HashBucket: - there is no dummy head node - head node now can take data - improved algorithms working with linked list
dbseraf
reviewed
Feb 1, 2017
| hashTable[i] = new HashBucket<K, V>(); //create the hash buckets | ||
| } | ||
| assert(hashSize_ > 0 && "Hash size muste be > 0"); | ||
| assert((hashSize_ & (hashSize_ - 1)) == 0 && "Hash size must be power of 2"); |
There was a problem hiding this comment.
Seriously, if you're going to change the API contract, you really must update the documentation.
Author
There was a problem hiding this comment.
What API constract and documentation are you talking about?
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope there is no hidden bug.