Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors context usage #21

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Refactors context usage #21

merged 6 commits into from
Apr 26, 2024

Conversation

ksysoev
Copy link
Owner

@ksysoev ksysoev commented Apr 25, 2024

Changing the way we distribute context through the components, instead of assigning context at channel, I decided to use base context of http server.

@ksysoev ksysoev marked this pull request as draft April 25, 2024 13:33
@ksysoev ksysoev changed the title Refactors context usage at server entity Refactors context usage Apr 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.91%. Comparing base (8f165ce) to head (9e607d1).

Files Patch % Lines
server/server.go 82.75% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   87.23%   88.91%   +1.67%     
==========================================
  Files          17       17              
  Lines         517      496      -21     
==========================================
- Hits          451      441      -10     
+ Misses         53       44       -9     
+ Partials       13       11       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksysoev ksysoev marked this pull request as ready for review April 26, 2024 12:13
@ksysoev ksysoev merged commit c1bd247 into main Apr 26, 2024
1 check passed
@ksysoev ksysoev deleted the context_everywhere branch April 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants