Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements graceful shutdown #22

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Implements graceful shutdown #22

merged 4 commits into from
Apr 27, 2024

Conversation

ksysoev
Copy link
Owner

@ksysoev ksysoev commented Apr 26, 2024

Implements graceful shutdown for components to address issue #4

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 77.94118% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 87.56%. Comparing base (c1bd247) to head (d11d48d).

Files Patch % Lines
server/server.go 68.42% 9 Missing and 3 partials ⚠️
channel/connection_registry.go 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   88.91%   87.56%   -1.35%     
==========================================
  Files          17       17              
  Lines         496      563      +67     
==========================================
+ Hits          441      493      +52     
- Misses         44       55      +11     
- Partials       11       15       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksysoev ksysoev merged commit bc9b61d into main Apr 27, 2024
1 check passed
@ksysoev ksysoev deleted the server_shutdown branch April 27, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants