Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds possibility to get address and port that used by the server #51

Merged
merged 4 commits into from
May 19, 2024

Conversation

ksysoev
Copy link
Owner

@ksysoev ksysoev commented May 18, 2024

This pull request adds a net.Listener field to the Server struct and updates the Run method to use the listener for starting the server. This change allows the server's network address to be retrieved using the new Addr method. Additionally, a new test case has been added to verify the behavior of the Addr method.

@ksysoev ksysoev marked this pull request as ready for review May 19, 2024 08:32
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.67%. Comparing base (dc190b1) to head (619ff6b).

Files Patch % Lines
server/server.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   88.38%   88.67%   +0.29%     
==========================================
  Files          18       18              
  Lines         723      742      +19     
==========================================
+ Hits          639      658      +19     
  Misses         63       63              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksysoev ksysoev changed the title Add net.Listener to Server struct and update Run method Adds possibility to get address and port that used be the server May 19, 2024
@ksysoev ksysoev changed the title Adds possibility to get address and port that used be the server Adds possibility to get address and port that used by the server May 19, 2024
@ksysoev ksysoev merged commit bdf051b into main May 19, 2024
1 check passed
@ksysoev ksysoev deleted the get_address_and_port branch May 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants