Introduce server config method(s) #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksysoev
reviewed
Jun 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 91.31% 91.58% +0.27%
==========================================
Files 20 21 +1
Lines 829 844 +15
==========================================
+ Hits 757 773 +16
+ Misses 53 52 -1
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
@ksysoev sorry for the delay. This PR is ready for review. I have changed a few things
|
shan-96
commented
Jun 23, 2024
shan-96
commented
Jun 23, 2024
ksysoev
reviewed
Jun 24, 2024
server/server.go
Outdated
| @@ -69,7 +64,7 @@ func WithReadinessChan(ch chan<- struct{}) Option { | |||
| // NewServer creates new instance of Wasabi server | |||
| // port - port to listen on | |||
| // returns new instance of Server | |||
| func NewServer(addr string, opts ...Option) *Server { | |||
| func NewServer(addr string, serverConfig ServerConfig, opts ...Option) *Server { | |||
There was a problem hiding this comment.
Let's not introduce new mandatory arguments, I think in majority of cases these timeouts don't need to be redefined and reasonable default can be use without bothering the user. I'd suggest to pass it as optional parameter.
There was a problem hiding this comment.
added an optional method
ksysoev
reviewed
Jun 24, 2024
ksysoev
reviewed
Jun 24, 2024
shan-96
commented
Jun 24, 2024
ksysoev
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68