feat: replace circuit breaker with library #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation of circuit breaker was simplistic. It is replaced with a third-party library "gobreaker/v2". The function signature "recoverAfter" was removed to fit the implementation of the library. Test cases for circuit breaker were modified accordingly.
ksysoev
reviewed
Jun 24, 2024
|
|
||
| lock := &sync.RWMutex{} | ||
| semiOpenLock := &sync.Mutex{} | ||
| func NewCircuitBreakerMiddleware(threshold uint, period time.Duration) func(next wasabi.RequestHandler) wasabi.RequestHandler { |
There was a problem hiding this comment.
Let's update type of threshold to uint32 to be in consistent.
ksysoev
reviewed
Jun 24, 2024
Comment on lines
52
to
53
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Could you check for gobreaker.ErrOpenState error and return instead ErrCircuitBreakerOpen to hide dependency on the gobreaker... to have possibility to replace library in the future.
ksysoev
reviewed
Jun 24, 2024
| "time" | ||
|
|
||
| "github.com/ksysoev/wasabi" | ||
| "github.com/ksysoev/wasabi/dispatch" | ||
| "github.com/sony/gobreaker/v2" | ||
| ) | ||
|
|
||
| type CircuitBreakerState uint8 |
There was a problem hiding this comment.
Probably this type is not needed anymore.
ksysoev
requested changes
Jun 24, 2024
ksysoev
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of circuit breaker was simplistic. It is replaced with a third-party library "gobreaker/v2". The function signature "recoverAfter" was removed to fit the implementation of the library. Test cases for circuit breaker were modified accordingly.
Closes #77