Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patterns): allow deferred and builder in Capture pattern #5

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix(patterns): allow deferred and builder in Capture pattern #5

merged 2 commits into from
Aug 6, 2024

Conversation

cpcloud
Copy link
Collaborator

@cpcloud cpcloud commented Aug 6, 2024 •
edited
Loading

Accept Deferred and Builder in Capture instead of only accepting str.

@cpcloud cpcloud force-pushed the allow-stated-types-in-capture branch from ab55372 to 8f6a9f8 Compare August 6, 2024 16:19
@cpcloud cpcloud force-pushed the allow-stated-types-in-capture branch from 8f6a9f8 to f129378 Compare August 6, 2024 16:21
@cpcloud cpcloud changed the title allow stated types in capture fix(patterns): allow deferred and builder in Capture pattern Aug 6, 2024
kszucs
kszucs reviewed Aug 6, 2024
View reviewed changes
koerce/patterns.py Outdated Show resolved Hide resolved
kszucs
kszucs approved these changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@kszucs kszucs merged commit 694156e into kszucs:main Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs