fix: Use conn_timeout for telnet connection #3034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elavaud
changed the title
k-ribot
force-pushed
the
use-conn_timeout-for-telnet-connection
branch
from
c932e0a
to
3949a02
Compare
|
Hi @ktbyers , any news on this one? :) |
k-ribot
force-pushed
the
use-conn_timeout-for-telnet-connection
branch
from
3949a02
to
e700a0c
Compare
|
Hi @ktbyers what do you think of this MR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ktbyers,
Doesn't it make more sense to use the
conn_timeoutrather thantimeoutfor the telnet connection?On SSH connection it is already the
conn_timeoutwhich is used.