fortinet _preferred_kex settings interfering with other devices #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: Noppes |
|
@Noppes I changed the logic a little bit and added some tests, I think it should all work the same, but let me know if you see any issues (and we can fix). |
in your change it looks like now self.disabled_algorithms can be None, while in the original it was always an empty dict then. Otherwise looks good 👌 |
|
Yes that is correct as None is the default in Paramiko
Kirk
On Sun, Nov 10, 2024 at 7:48 AM Noppes ***@***.***> wrote:
CC: Noppes <https://github.com/Noppes>
in your change it looks like now self.disabled_algorithms can be None,
while in the original it was always an empty dict then
—
Reply to this email directly, view it on GitHub
<#3530 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG3VBFP5MA2IVEFE3EKEC3Z7556XAVCNFSM6AAAAABROBOOIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWG44DIOBXGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Kirk Byers
***@***.***
Simplify through Automation
* <https://pynet.twb-tech.com>*
|
|
Basically, we shouldn't change the value from the Paramiko default unless we are actually doing something with the variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.