DPL: add test for exception throwing in Variant

ktf · Nov 25, 2024 · acbee81 · acbee81
1 parent 4f7d71b
commit acbee81
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/Framework/Core/include/Framework/Variant.h b/Framework/Core/include/Framework/Variant.h
@@ -355,7 +355,7 @@ class Variant
   T get() const
   {
     if (mType != variant_trait_v<T>) {
-      throw runtime_error("Mismatch between types");
+      throw runtime_error_f("Variant::get: Mismatch between types %d %d.", mType, variant_trait_v<T>);
     }
     return variant_helper<T>::get(&mStore);
   }

diff --git a/Framework/Core/test/test_Variants.cxx b/Framework/Core/test/test_Variants.cxx
@@ -338,3 +338,15 @@ TEST_CASE("VariantJSONConversionsTest")
     REQUIRE(vstrings[i] == vvstra.get<std::string*>()[i]);
   }
 }
+
+TEST_CASE("VariantThrowing")
+{
+  Variant a("true");
+  REQUIRE_THROWS_AS(a.get<int>(), o2::framework::RuntimeErrorRef);
+  try {
+    a.get<int>();
+  } catch (RuntimeErrorRef& ref) {
+    RuntimeError& error = error_from_ref(ref);
+    REQUIRE(error.what == std::string("Variant::get: Mismatch between types 4 0."));
+  }
+}