Merge pull request #258 from kthcloud/dev

fix dont ping private deployments
kthcloud · Nov 9, 2023 · 19a5094 · 19a5094
2 parents 7c5f228 + 8b7ab55
commit 19a5094
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/pkg/workers/ping/workers.go b/pkg/workers/ping/workers.go
@@ -40,13 +40,7 @@ func deploymentPingUpdater(ctx context.Context) {
 
 func pingDeployment(deployment *deploymentModels.Deployment) {
 	makeError := func(err error) error {
-		return fmt.Errorf("failed to ping deployments. details: %w", err)
-	}
-
-	baseURL := deployment.GetURL()
-	if baseURL == nil {
-		utils.PrettyPrintError(makeError(fmt.Errorf("deployment %s has no url", deployment.Name)))
-		return
+		return fmt.Errorf("failed to ping deployment. details: %w", err)
 	}
 
 	mainApp := deployment.GetMainApp()
@@ -55,6 +49,16 @@ func pingDeployment(deployment *deploymentModels.Deployment) {
 		return
 	}
 
+	if mainApp.Private {
+		return
+	}
+
+	baseURL := deployment.GetURL()
+	if baseURL == nil {
+		utils.PrettyPrintError(makeError(fmt.Errorf("deployment %s has no url", deployment.Name)))
+		return
+	}
+
 	subPath := mainApp.PingPath
 	if len(mainApp.PingPath) > 0 && !strings.HasPrefix(mainApp.PingPath, "/") {
 		subPath = "/" + subPath