🐛 fix: select most specific LSP server based on rootDir #22
+245
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #23
When multiple LSP servers support the same file extension with different
rootDirvalues (common in monorepos), cclsp was selecting the first matching server regardless of which workspace the file belongs to.Root Cause
The
getServerForFile()method used first-match logic based only on file extension:This ignored the
rootDirconfiguration entirely.Solution
When multiple servers match a file's extension, now selects the server whose
rootDirmost specifically contains the file (longest matching path). This ensures each file is analyzed by the correct workspace-aware LSP server.Example:
{ "servers": [ { "extensions": ["ts"], "command": ["ts-server"], "rootDir": "." }, { "extensions": ["ts"], "command": ["ts-server"], "rootDir": "repos/app" } ] }File at
repos/app/src/test.ts→ Uses server withrootDir: "repos/app"(more specific)File at
other/test.ts→ Uses server withrootDir: "."(fallback)Changes
getServerForFile()to select based on most specificrootDirTesting
✅ All existing tests pass (158 tests)
✅ Added 7 new test cases for server selection
✅ Linting and type checking pass
bun test src/server-selection.test.ts 7 pass 0 fail