feat: add new LSP tools (hover, workspace_symbol, find_implementation… #28
+675
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jye10032
force-pushed
the
feature/add-lsp-tools
branch
2 times, most recently
from
bcdc88b to
f32c6ba
Compare
Add the following new MCP tools to match Claude Code's built-in LSP capabilities: - get_hover: Get hover information (documentation, type info) for a symbol - find_workspace_symbols: Search for symbols across the entire workspace - find_implementation: Find implementations of interfaces/abstract methods - prepare_call_hierarchy: Get call hierarchy item at a position - get_incoming_calls: Find all callers of a function - get_outgoing_calls: Find all functions called by a function Changes: - src/types.ts: Add CallHierarchyItem, CallHierarchyIncomingCall, CallHierarchyOutgoingCall types - src/lsp-client.ts: Add hover(), workspaceSymbol(), findImplementation(), prepareCallHierarchy(), incomingCalls(), outgoingCalls() methods - index.ts: Add MCP tool definitions and handlers for all new tools
Jye10032
force-pushed
the
feature/add-lsp-tools
branch
from
f32c6ba to
3512e85
Compare
Owner
|
@Jye10032 Hi sorry for the late response. Would be happy to hear back from you! |
ktnyt
reviewed
Jan 2, 2026
Owner
ktnyt
left a comment
ktnyt
left a comment
There was a problem hiding this comment.
レビューコメント
全体的に良い実装ですが、いくつか改善点があります：
重要な問題
- URIからファイルパスの変換:
incomingCallsとoutgoingCallsでitem.uri.replace('file://', '')を使っていますが、これはWindowsパスで正しく動作しません。既存のuriToPathユーティリティ関数を使うべきです。
改善提案
-
workspaceSymbolの複数サーバー対応: 複数のLSPサーバーが実行されている場合、すべてのサーバーから結果を取得する方が良いでしょう。
-
ensureFileOpenの戻り値: PR #30の変更と整合性を取るため、
hover、findImplementation、prepareCallHierarchyでもファイルが初めて開かれた場合の待機時間を検討してください。 -
パフォーマンス最適化:
get_incoming_callsとget_outgoing_callsでprepareCallHierarchyを毎回呼び出していますが、キャッシュを検討できます。
良い点
- 型定義が適切に追加されている
- エラーハンドリングが一貫している
- デバッグログが適切に追加されている
- 既存のコードスタイルと整合している
特に1番の問題は修正が必要です。他の点は改善提案です。
ktnyt
added a commit
that referenced
this pull request
Jan 2, 2026
…ementation, prepareCallHierarchy, incomingCalls, outgoingCalls) Add comprehensive test coverage for the 6 new LSP methods added in PR #28: - hover: Test hover information retrieval and null handling - workspaceSymbol: Test workspace-wide symbol search with multiple scenarios - findImplementation: Test implementation finding with array and object results - prepareCallHierarchy: Test call hierarchy preparation - incomingCalls: Test incoming calls retrieval (includes uriToPath usage verification) - outgoingCalls: Test outgoing calls retrieval (includes uriToPath usage verification) All tests follow the existing test patterns using mocks for getServer, ensureFileOpen, and sendRequest methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add 6 new LSP tools
Add the following new MCP tools to match Claude Code's built-in LSP capabilities:
Changes: