fix: wait for project indexing after didOpen to fix incomplete find_references #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences Fixes #27 The first find_references call per session was returning incomplete results (only the definition) because the LSP server hadn't finished indexing the project yet when the request was made. Changes: - Modified ensureFileOpen to return a boolean indicating if the file was just opened (vs already open) - Added a 200ms wait after opening a file for the first time in findReferences and findDefinition to give the LSP server time to process the didOpen notification and start indexing the project This ensures that workspace-wide operations like find_references return complete results even on the first call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Problem
The first
find_referencescall per session was returning incomplete results (only the definition) because the LSP server hadn't finished indexing the project yet when the request was made.Solution
ensureFileOpento return a boolean indicating if the file was just opened (vs already open)findReferencesandfindDefinitionto give the LSP server time to process thedidOpennotification and start indexing the projectThis ensures that workspace-wide operations like
find_referencesreturn complete results even on the first call.Testing