Use PreciseNumber as a base for calculations and only do significance operations in this library #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync main to precise-number branch
- Removed outdated tests from AITests.cs and cleaned up Tests.cs. - Added comprehensive tests for SignificantNumber in SignificantNumberTests.cs. - Updated SignificantNumber class with new methods for creation, incrementing, and decrementing. - Updated SignificantNumberExtensions for better conversion handling. - Updated project to reference a newer version of ktsu.PreciseNumber.
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (1)
- SignificantNumber/SignificantNumber.csproj: Language not supported
Comments suppressed due to low confidence (3)
SignificantNumber/SignificantNumberExtensions.cs:59
- Consider adding unit tests to verify the behavior of the ReduceSignificance operation and the overall conversion, especially for edge case inputs.
var preciseNumber = input.ToPreciseNumber().ReduceSignificance(significantDigits);
SignificantNumber.Test/InvalidNumber.cs:1
- The removal of InvalidNumber tests may reduce coverage for exception handling scenarios; please ensure that these cases are adequately tested elsewhere.
namespace ktsu.SignificantNumber.Test;
SignificantNumber.Test/Helpers.cs:1
- Removal of the Helpers file might impact test maintainability; confirm that the necessary test utilities are available in your remaining test suite.
// Ignore Spelling: RNG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.