Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kuring-123 [수정] DateUtilTest가 간헐적으로 실패하던 문제 해결 #90

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

mwy3055
Copy link
Member

@mwy3055 mwy3055 commented Jan 30, 2024

https://kuring.atlassian.net/browse/KURING-123

배경

CI 과정에서 DateUtilTest가 간헐적으로 실패하는 문제가 있었습니다. 해당 테스트는 두 java.util.Calendar 객체 간의 epoch의 차이를 계산하는 테스트입니다.

수정 내용

DateUtil.getCalendar() 함수에서 대부분의 필드를 주어진 값으로 설정하지만, Calendar.MILLISECOND 필드는 설정하지 않고 있었습니다. 따라서 getCalendar() 함수에서 Calendar 객체를 만들 때 MILLISECOND 필드를 0으로 설정하도록 수정했습니다.

@auto-assign auto-assign bot requested a review from yeon-kyu January 30, 2024 05:48
Copy link
Member

@yeon-kyu yeon-kyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요게 원인이었군요 고생하셨습니다~

@mwy3055 mwy3055 merged commit deaa5e1 into 2.0/base Jan 31, 2024
2 checks passed
@mwy3055 mwy3055 deleted the 2.0/fix-test branch January 31, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants