kuring-98 학과 편집 화면 2.0 디자인 구현 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string id가 겹치면 이렇게 된다.
DB에서 학과 구독 작업은 영문 풀네임으로 이루어진다.
x-0o0
reviewed
Jan 31, 2024
.../designsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/DepartmentItems.kt
Show resolved
Hide resolved
|
으악 하나 실수했습니다 ㅠㅠ |
x-0o0
reviewed
Feb 1, 2024
...esignsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/KuringAlertDIalog.kt
Outdated
Show resolved
Hide resolved
...nsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/TransparentIconButton.kt
Outdated
Show resolved
Hide resolved
yeon-kyu
reviewed
Feb 4, 2024
...esignsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/KuringAlertDialog.kt
Show resolved
Hide resolved
..._departments/src/main/java/com/ku_stacks/ku_ring/edit_departments/compose/EditDepartments.kt
Outdated
Show resolved
Hide resolved
...n/designsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/LargeTopAppBar.kt
Outdated
Show resolved
Hide resolved
...nsystem/src/main/java/com/ku_stacks/ku_ring/designsystem/components/TransparentIconButton.kt
Outdated
Show resolved
Hide resolved
Edit Commit Message 하시고 force-push 하시면 PR유지되면서 변경됩니다ㅎㅎ |
Or squash & merge 할거라면 스쿼시 할때 메세지 수정 하시면 됩니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kuring.atlassian.net/browse/KURING-98?atlOrigin=eyJpIjoiNzk5MGYzM2YyOGViNDZiNWIwZmZmMGZhMWE5ODczMTEiLCJwIjoiaiJ9
학과 편집 화면에 2.0 디자인을 적용했습니다.
_2024_01_31_17_00_55_571.mp4
구현 상세
대부분 Figma 디자인대로 구현했습니다.
다만,
모두 삭제버튼을 눌렀을 때의 화면은 디자인되어 있지 않아, 임의로 팝업을 추가했습니다. 이 부분은 디자인 팀과 논의 후 수정할 예정입니다.