Sourcery Starbot ⭐ refactored kuba2k2/espionage-bot #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
May 9, 2022
espionage.py
Outdated
| self.sf2s = sf2s | ||
| self.bot.event(self.on_voice_state_update) | ||
| for name in files.keys(): | ||
| for name in files: |
Author
There was a problem hiding this comment.
Function Espionage.__init__ refactored with the following changes:
- Remove unnecessary call to keys() (
remove-dict-keys)
espionage.py
Outdated
Comment on lines
-90
to
+92
| cmd=ESPIONAGE_FILE if not member.guild.voice_client else None, | ||
| cmd=None if member.guild.voice_client else ESPIONAGE_FILE, | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function Espionage.on_voice_state_update refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression)
music.py
Outdated
| cmd = await ensure_command(ctx, name, self.files) | ||
| pack = "pack" in cmd and cmd["pack"] | ||
| if pack: | ||
| if pack := "pack" in cmd and cmd["pack"]: |
Author
There was a problem hiding this comment.
Function Music.loop refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
music.py
Outdated
Comment on lines
-90
to
+92
| f"Speed changing is not possible - missing file metadata.", | ||
| "Speed changing is not possible - missing file metadata.", | ||
| delete_after=10, | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function Music.speed refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
start.py
Outdated
| def migrate(file: dict) -> bool: | ||
| migrated = False | ||
| version = file["version"] if "version" in file else 1 | ||
| version = file.get("version", 1) |
Author
There was a problem hiding this comment.
Function migrate refactored with the following changes:
- Simplify dictionary access using default get (
default-get)
utils.py
Outdated
Comment on lines
-166
to
+153
| if not voice: | ||
| return False | ||
| return len(voice.channel.voice_states) <= 1 | ||
| return len(voice.channel.voice_states) <= 1 if voice else False |
Author
There was a problem hiding this comment.
Function is_alone refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
utils.py
Outdated
Comment on lines
-178
to
+163
| await ctx.send(f"User is not connected to a voice channel.", delete_after=3) | ||
| await ctx.send("User is not connected to a voice channel.", delete_after=3) |
Author
There was a problem hiding this comment.
Function ensure_voice refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
utils.py
Outdated
Comment on lines
-192
to
+180
| f"Only the author of the file or an admin can modify/remove it.", | ||
| "Only the author of the file or an admin can modify/remove it.", | ||
| delete_after=3, | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function ensure_can_modify refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
utils.py
Outdated
Comment on lines
-229
to
+221
| soundfont = "audio/x-sfbk" == mime_type or "SoundFont/Bank" in mime_text | ||
| soundfont = mime_type == "audio/x-sfbk" or "SoundFont/Bank" in mime_text | ||
| if soundfont: | ||
| return False, False, True, False, False | ||
| audio = mime_type.startswith("audio/") | ||
| video = mime_type.startswith("video/") | ||
| archive = mime_type in archive_mimetypes | ||
| midi = "audio/midi" == mime_type | ||
| midi = mime_type == "audio/midi" |
Author
There was a problem hiding this comment.
Function check_file refactored with the following changes:
- Ensure constant in comparison is on the right (
flip-comparison)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: