Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API rework #56

Merged
merged 51 commits into from
Jan 4, 2024
Merged

API rework #56

merged 51 commits into from
Jan 4, 2024

Conversation

kubagalecki
Copy link
Owner

No description provided.

@kubagalecki
wip: renamespace the project
5332161
@kubagalecki
wip: renamespace the project
05f9626
@kubagalecki
closes #54; closes #55
c45481c
@kubagalecki
renamespaced utils
74a1389
@kubagalecki
codecov metrics now purely informational
24cb01f
@kubagalecki
updated benchmarks in line with new namespaces
0c2eb77
@kubagalecki
renamespaced solvers
60c1c0e
@kubagalecki
renamed ElementTypes to ElementType
dfdcab8
@kubagalecki
renamespaced mesh
d503de7
@kubagalecki
moved mesh serialization facilities to mesh
cabff1c
@kubagalecki
updated subdirectory readmes
2559856
@kubagalecki
moved SolutionManager.hpp to post
9868d87
@kubagalecki
moved general DOF handling facilities to separate dofs directory
26eedf2
@kubagalecki
renamed assembly directory to glob_asm (matrix-free is coming)
bc85996
@kubagalecki
renamespaced dof directory
be769aa
@kubagalecki
cleaned up MPIScopeGuard ctor
810f604
@kubagalecki
factored array<node>->DOFs mapping into separate file
a9fa317
@kubagalecki
Updated ProblemDef
458dd86
@kubagalecki
renamespaced global assembly
20903ed
@kubagalecki
removed detail namespace from dofs
953163d
@kubagalecki
further namespace refactoring
c5c923b
@kubagalecki
further reduced use of the detail namespace
bdce024
@kubagalecki
renamespaced comm
db0e2b8
@kubagalecki
renamespaced post
7cde4da
@kubagalecki
mesh now passed around via shared pointer
22e66a6
@kubagalecki
computeValuesAtNodes now takes std::array instead of CT-wrapped range
58550b2
@kubagalecki
sane interface for assembly kernels
60b859a
@kubagalecki
simplified kernel argument lifetime semantics
2c2ff41
@kubagalecki
kernels for computeValuesAtNodes
51f52d9
@kubagalecki
mesh internals refactor
78ff5fd
@kubagalecki
MaxParallelismGuard now only throttles max threads (similar to TBB …
5b54d8f 
…behavior)
@kubagalecki
New solver and preconditioner interface
b2cca5a
@kubagalecki
Added some barriers for profiled builds
174de62
@kubagalecki
WIP: precompute sparsity graph column map to avoid costly global asse…
67aabe4 
…mbly
@kubagalecki
The sparsity graph is now assembled in terms of local indices. This s…
b292a84 
…hould speed up initialization, since Tpetra does not need to compute the column map of the graph.
@kubagalecki
Fixed compiler warnings
6744fca
@kubagalecki
Parallel insertion into Tpetra::FECrsGraph
ea7286c
@kubagalecki
Removed algebraic system caching, parameter list now includes #rhs
43fc08e
@kubagalecki
Merged VTK tests back together
362dc66
@kubagalecki
Multiple RHS now supported
2539c6e
@kubagalecki
small updates to trilinos cmake
c37a2a2
@kubagalecki
Decreased debug test sizes to reduce CI time
6b15c12
@kubagalecki
minor refactor
dc53a13
@kubagalecki
API for computing values at nodes
82b5803
@kubagalecki
Unified Domain and Boundary kernel interface
88477c7
@kubagalecki kubagalecki self-assigned this Jan 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

Attention: 405 lines in your changes are missing coverage. Please review.

Comparison is base (346a8eb) 83.51% compared to head (eedc2f3) 83.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   83.51%   83.59%   +0.08%     
==========================================
  Files          81       87       +6     
  Lines        4300     4888     +588     
  Branches     1746     2059     +313     
==========================================
+ Hits         3591     4086     +495     
- Misses         60       70      +10     
- Partials      649      732      +83
Files Coverage Δ
include/l3ster/basisfun/ReferenceBasisAtPoints.hpp 100.00% <ø> (+71.42%) ⬆️
include/l3ster/comm/GatherNodeThroughputs.hpp 100.00% <ø> (ø)
include/l3ster/common/KernelInterface.hpp 100.00% <100.00%> (ø)
include/l3ster/common/Structs.hpp 95.23% <100.00%> (ø)
include/l3ster/dofs/MakeTpetraMap.hpp 100.00% <100.00%> (ø)
include/l3ster/dofs/ProblemDefinition.hpp 100.00% <100.00%> (ø)
include/l3ster/glob_asm/ScatterLocalSystem.hpp 100.00% <100.00%> (ø)
...nclude/l3ster/mapping/BoundaryIntegralJacobian.hpp 100.00% <ø> (ø)
include/l3ster/mapping/BoundaryNormal.hpp 97.50% <100.00%> (ø)
include/l3ster/mapping/ComputePhysBasisDer.hpp 100.00% <100.00%> (ø)
... and 76 more

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346a8eb...eedc2f3. Read the comment docs.

@kubagalecki kubagalecki marked this pull request as ready for review January 4, 2024 17:00
@kubagalecki kubagalecki merged commit 586d0b7 into main Jan 4, 2024
9 of 10 checks passed
@kubagalecki kubagalecki deleted the api-rework branch January 4, 2024 17:00
This was linked to issues Jan 11, 2024
Test if initial stack size is less than numeric_limits::max() #55
Closed
Machine topology tests fail on ICM's Topola machine #54
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kubagalecki kubagalecki

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kubagalecki