Remove content type header for /prediction/speccost API calls #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the server-side change in https://github.com/kubecost/kubecost-cost-model/pull/1916 with |
michaelmdresser
force-pushed
the
mmd/remove-content-type
branch
from
95edbe3
to
760bc6d
Compare
Backend no longer requires it, makes us flexible for yaml and json
michaelmdresser
force-pushed
the
mmd/remove-content-type
branch
from
760bc6d
to
8a040bd
Compare
saweber
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Remove content type header for /prediction/speccost calls
Backend no longer requires it, makes us flexible
for yaml and json
Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Added JSON manifest support to
kubectl cost predictHow was this PR tested?
Have you made an update to documentation?