-
Notifications
You must be signed in to change notification settings - Fork 22
test: update stop update run integration test #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+228
−446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Dec 19, 2025
Arvindthiru
reviewed
Dec 19, 2025
Arvindthiru
reviewed
Dec 30, 2025
Arvindthiru
reviewed
Dec 31, 2025
Arvindthiru
reviewed
Dec 31, 2025
Arvindthiru
reviewed
Dec 31, 2025
Arvindthiru
reviewed
Dec 31, 2025
Arvindthiru
reviewed
Dec 31, 2025
Arvindthiru
reviewed
Dec 31, 2025
Arvindthiru
reviewed
Dec 31, 2025
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
reviewed
Jan 7, 2026
Arvindthiru
reviewed
Jan 7, 2026
Arvindthiru
reviewed
Jan 7, 2026
Arvindthiru
reviewed
Jan 7, 2026
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
Arvindthiru
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
Add a case to test stopping in between delete stage
Reduce the cluster and stage size.
Fix to check updateRun is in stopping state CONSISTENTLY.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Addressed comments as a follow up PR of #374
This is the test flow: beforeStage -> stop -> cluster 1 -> stop -> afterStage -> stop -> deleteStage -> stop -> continue to complete.