Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update the Kubeflow Commit for Katib UI #2313

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

andreyvelich
Copy link
Member

I updated commit that might help to fix Katib UI CI/CD.

/assign @kubeflow/wg-automl-leads @kimwnasptd @elenzio9 @apo-ger

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member Author

@kimwnasptd @kubeflow/wg-notebooks-leads I might need your help to debug CI/CD for Katib UI since it is related to CRUD WebApps

@andreyvelich
Copy link
Member Author

@orfeas-k @kimwnasptd Any thoughts on this error ? If we can't debug it before the release, we can temporarily disable unit tests for Katib UI

  1) Index page
       renders properly Status icon for all  experiments:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `lib-status>mat-icon`, but never found it. Queried from element: <td.mat-cell.cdk-cell.cdk-column-status.mat-column-status.ng-star-inserted>
      at Context.eval (webpack:///./cypress/e2e/index-page.cy.ts:56:11)

@orfeas-k
Copy link
Contributor

Could you try the following change from here? This should do the fix if the previous Kubeflow commit was a very old one.

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 24, 2024
@andreyvelich
Copy link
Member Author

Could you try the following change from here? This should do the fix if the previous Kubeflow commit was a very old one.

@orfeas-k I still can see the following error:

There was an error reconnecting to the Chrome DevTools protocol. Please restart the browser.

Error: connect ECONNREFUSED 127.0.0.1:40069
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1187:16)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! frontend@0.0.0 ui-test-ci-all: `cypress run . --e2e --browser=chrome && cypress run . --e2e --browser=firefox`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the frontend@0.0.0 ui-test-ci-all script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2024-04-24T15_23_36_465Z-debug.log
Error: Process completed with exit code 1.

Do we need to make any other changes ?

@orfeas-k
Copy link
Contributor

@andreyvelich Unfortunately, it's the first time I see this error. Cypress has the following issue cypress-io/cypress#26900 for which they released a fix in 12.17. However, I 'm afraid that just bumping cypress two major versions will need some work.

@andreyvelich
Copy link
Member Author

@andreyvelich Unfortunately, it's the first time I see this error. Cypress has the following issue cypress-io/cypress#26900 for which they released a fix in 12.17. However, I 'm afraid that just bumping cypress two major versions will need some work.

Does Cypress have some breaking changes that we need to make if we update the version ?

@andreyvelich andreyvelich mentioned this pull request Apr 26, 2024
10 tasks
@orfeas-k
Copy link
Contributor

@andreyvelich I haven't done that migration in the past myself but reading the docs, there are quite a few breaking changes going from 10->11 and 11->12, so I expect we 'd hit at least some of them.

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member Author

@orfeas-k @kubeflow/wg-notebooks-leads Any updates here ?
Did you migrate to the new version of Cypress for Central Dashboard or Notebooks UI tests ?

@andreyvelich
Copy link
Member Author

andreyvelich commented Jun 12, 2024

Hi @orfeas-k @kimwnasptd any thoughts who can help us with CI problems for Katib UI ?
Given it is broken all other PRs which change Katib UI can't be merged.

@orfeas-k
Copy link
Contributor

Could you try bumping the node version this runs on? https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-120

who can help us with CI problems for Katib UI ?

I don't have sb in mind. I can try allocating some time next week but I can't promise about it.

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

Hi @orfeas-k @kimwnasptd, do you have any bandwidth to help us with broken CI for Katib UI ?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants