-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Update the Kubeflow Commit for Katib UI #2313
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we need to change there: https://github.com/tenzen-y/katib/blob/714929384bfb6a3a2c3d5b9769f3b1bb6e8ba9bf/pkg/ui/v1beta1/frontend/src/styles.scss#L2
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@kimwnasptd @kubeflow/wg-notebooks-leads I might need your help to debug CI/CD for Katib UI since it is related to CRUD WebApps |
@orfeas-k @kimwnasptd Any thoughts on this error ? If we can't debug it before the release, we can temporarily disable unit tests for Katib UI
|
Could you try the following change from here? This should do the fix if the previous Kubeflow commit was a very old one. |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@orfeas-k I still can see the following error:
Do we need to make any other changes ? |
@andreyvelich Unfortunately, it's the first time I see this error. Cypress has the following issue cypress-io/cypress#26900 for which they released a fix in 12.17. However, I 'm afraid that just bumping cypress two major versions will need some work. |
Does Cypress have some breaking changes that we need to make if we update the version ? |
@andreyvelich I haven't done that migration in the past myself but reading the docs, there are quite a few breaking changes going from 10->11 and 11->12, so I expect we 'd hit at least some of them. |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@orfeas-k @kubeflow/wg-notebooks-leads Any updates here ? |
Hi @orfeas-k @kimwnasptd any thoughts who can help us with CI problems for Katib UI ? |
Could you try bumping the node version this runs on? https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-120
I don't have sb in mind. I can try allocating some time next week but I can't promise about it. |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @orfeas-k @kimwnasptd, do you have any bandwidth to help us with broken CI for Katib UI ? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
I updated commit that might help to fix Katib UI CI/CD.
/assign @kubeflow/wg-automl-leads @kimwnasptd @elenzio9 @apo-ger