Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipeline-loop v2): Merge loop driver and publisher into the pipelineloop controller logic #1428

Merged
merged 5 commits into from
Dec 18, 2023
Merged

feat(pipeline-loop v2): Merge loop driver and publisher into the pipelineloop controller logic #1428

merged 5 commits into from
Dec 18, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Dec 18, 2023

Which issue is resolved by this Pull Request:
Part of #1419

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli Tomcli changed the title (wip) Merge loop driver and publisher into the pipelineloop controller logic feat(pipeline-loop v2): Merge loop driver and publisher into the pipelineloop controller logic Dec 18, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Dec 18, 2023

/assign @yhwang
This PR won't impact the v1 behavior and only enable KFPV2 mode for KFP-Tekton 2.0.4+ release.

yhwang
yhwang approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 18, 2023
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b6fcff9 into kubeflow:master Dec 18, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhwang yhwang yhwang approved these changes

@ckadner ckadner Awaiting requested review from ckadner

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@yhwang yhwang

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomcli @yhwang