Skip to content

feat(ws): implement culling controller #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: notebooks-v2
Choose a base branch
from
Open

feat(ws): implement culling controller #63

wants to merge 13 commits into from
+858 −32

Conversation

@Adembc
Copy link
Contributor

@Adembc Adembc commented Oct 7, 2024 •
edited by thesuperzapper
Loading

Closes #38

WIP

@Adembc Adembc force-pushed the culling-controller branch from 180adaa to c69b062 Compare October 10, 2024 20:53
@Adembc Adembc force-pushed the culling-controller branch from c69b062 to b26157f Compare November 9, 2024 15:06
@Adembc Adembc marked this pull request as ready for review November 9, 2024 15:36
@Adembc Adembc force-pushed the culling-controller branch from 74ab3ff to 243cb32 Compare February 7, 2025 19:30
Adembc added 13 commits February 12, 2025 08:49
@Adembc
feat(ws): implement culling controller
7f5cfac 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
update workspace kind crd
a96e96e 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
wip
31ef847 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
fetch podName
ab125ae 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
implment bash probe
39cebf5 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
implment bash probe
29f04f6 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
implment bash probe
78a465d 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
fix tests
b1739f8 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
get ws port
da19de1 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
update rbac
d28d7cd 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
rebase
37bcc19 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
fix lint problems
838baa5 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
fix tests
ce8ed92 
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc Adembc force-pushed the culling-controller branch from ad4904c to ce8ed92 Compare February 12, 2025 07:50
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this pull request from being marked as stale.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

This pull request has been automatically closed because it has not had recent activity.
You can reopen the PR if you want.

@github-actions github-actions bot closed this Oct 21, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Oct 21, 2025
@google-oss-prow google-oss-prow bot added the area/controller area - related to controller components label Oct 28, 2025
@google-oss-prow google-oss-prow bot added the area/v2 area - version - kubeflow notebooks v2 label Oct 28, 2025
@google-oss-prow
Copy link

google-oss-prow bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees

No one assigned

Labels

area/controller area - related to controller components area/v2 area - version - kubeflow notebooks v2 size/XL

Projects

Kubeflow Notebooks
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Adembc @thesuperzapper