feat: stub secrets API endpoints #667
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/backend
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/v2
andyatmiami
force-pushed
the
feat/secrets-api-stub
branch
4 times, most recently
from
5e56656 to
be67e88
Compare
Contributor
Author
|
/ok-to-test |
|
|
||
| // SecretValue represents a secret value with base64 encoding | ||
| type SecretValue struct { | ||
| Base64 string `json:"base64,omitempty"` |
Member
There was a problem hiding this comment.
A secret value can be empty, so it needs to be a pointer to a string.
This commit introduces a stub of the secrets management API to the Kubeflow Notebooks
workspace backend. It is intended to bootstrap API development but will require
follow up work to actually implement the business logic in line with the API proposal.
**API Endpoints Added:**
- GET /api/v1/secrets/{namespace} - List all secrets in namespace
- POST /api/v1/secrets/{namespace} - Create new secret
- GET /api/v1/secrets/{namespace}/{name} - Get specific secret details
- PUT /api/v1/secrets/{namespace}/{name} - Update existing secret
- DELETE /api/v1/secrets/{namespace}/{name} - Delete secret
**Key Features:**
- Complete data models for secret operations (create, update, list, detail)
- Comprehensive validation for secret keys and base64-encoded values
- Full Swagger/OpenAPI documentation generation
- Integration with existing authentication and authorization middleware
- Support for secret mounting information and audit trails
- Proper error handling and HTTP status codes
**Known Omissions:**
- No repository/ support for the stubbed API implementations
- API serves mocked data for all requests and does not actually interact k8s cluster
- Unit tests are very crude and presently rely on mocked data
- Missing business logic for majority of API handlers
This implementation provides the foundation for frontend integration to manage Kubernetes
secrets through the workspace interface.
Signed-off-by: Andy Stoneberg <astonebe@redhat.com>
andyatmiami
force-pushed
the
feat/secrets-api-stub
branch
from
be67e88 to
895e384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #655
This commit introduces a stub of the secrets management API to the Kubeflow Notebooks
workspace backend.
API Endpoints Added:
Key Features:
Known Omissions:
This implementation provides the foundation for frontend integration to manage Kubernetes
secrets through the workspace interface.