-
Notifications
You must be signed in to change notification settings - Fork 68
chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v1
Are you sure you want to change the base?
chore: Update Go module paths from kubeflow/kubeflow to kubeflow/notebooks #708
Conversation
86514c9 to
86e73b1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
86e73b1 to
ad642c1
Compare
|
/hold we will want to rebase this after #702 is merged. |
andyatmiami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general - I am comfortable with the changes included in this PR. I am just holding off on the lgtm until after we rebase this once #702 is merged so the CI workflows can do their magic .
…books - Updated module declarations in 3 go.mod files (notebook-controller, tensorboard-controller, pvcviewer-controller) - Updated all internal import statements in Go source files to match new module paths - Updated reconcilehelper imports to use local paths (after PR kubeflow#702 moved reconcilehelper into each controller) - Verified all components compile successfully Fixes kubeflow#699 Signed-off-by: Asaad Balum <asaad.balum@gmail.com>
ad642c1 to
86846b6
Compare
@andyatmiami Rebased on PR #702 and resolved conflicts. All components compile successfully. Ready for review! |
This PR updates all Go module paths from
github.com/kubeflow/kubeflowtogithub.com/kubeflow/notebooksas part of the repository migration.Changes Made
1. Updated Module Declarations (3 files)
components/notebook-controller/go.modcomponents/tensorboard-controller/go.modcomponents/pvcviewer-controller/go.modChanged module paths from:
to:
2. Updated Import Statements (19 Go source files)
All internal import statements now reference
github.com/kubeflow/notebooksto match the new module declarations.This includes updating imports for the local
reconcilehelper(which was moved into each controller in PR #702).Files updated:
components/notebook-controller/main.goand controllerscomponents/notebook-controller/api/v1/*.goandv1alpha1/*.gocomponents/tensorboard-controller/main.goand controllerscomponents/pvcviewer-controller/main.goand controllersTesting
✅ All components compile successfully
Files Changed
go.modfiles*.gosource filesAcceptance Criteria from #699
go.modfiles referencekubeflow/notebooksinstead ofkubeflow/kubeflowCloses #699