Skip to content

feat: secret attachment modal #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: notebooks-v2
Choose a base branch
from
Draft

feat: secret attachment modal #713

wants to merge 2 commits into from
+672 −123

Conversation

@thaorell
Copy link

@thaorell thaorell commented Nov 6, 2025 •
edited
Loading

Description:

  • Created a secrets attachment modal, which allows users to mount existing Secrets from the /secrets/${namespace} endpoint to the creation flow
  • Refactored secret create modal to its own file

closes: #660
depends on: #671

@thaorell
Generate frontend client endpoints for Secrets API
2004531 
Signed-off-by: Charles Thao <cthao@redhat.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Nov 6, 2025
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Nov 6, 2025
@google-oss-prow google-oss-prow bot requested a review from ederign November 6, 2025 18:33
@google-oss-prow
Copy link

google-oss-prow bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from paulovmr November 6, 2025 18:33
@google-oss-prow google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 size/XL labels Nov 6, 2025
@thaorell thaorell marked this pull request as draft November 6, 2025 18:33
@thaorell thaorell changed the title Secret attachment modal feat: secret attachment modal Nov 6, 2025
@thaorell thaorell force-pushed the secret_attachment_modal branch from f9f5986 to 4f72bbe Compare November 6, 2025 18:40
@thaorell
Copy link
Author

thaorell commented Nov 6, 2025

Screen.Recording.2025-11-06.at.1.41.31.PM.mov

@thaorell
draft: attach modal
803fe13 
Signed-off-by: Charles Thao <cthao@redhat.com>
@thaorell thaorell force-pushed the secret_attachment_modal branch from 4f72bbe to 803fe13 Compare November 6, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ederign ederign Awaiting requested review from ederign

@paulovmr paulovmr Awaiting requested review from paulovmr

Assignees

No one assigned

Labels

area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 do-not-merge/work-in-progress size/XL

Projects

Kubeflow Notebooks
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thaorell