Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline_spec in oss #10952

Closed
wants to merge 2 commits into from

Conversation

rickyxie0929
Copy link
Contributor

@rickyxie0929 rickyxie0929 commented Jun 24, 2024

Description of your changes:

Checklist:

Signed-off-by: rickyxie0929 <rickyxie@google.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neuromage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rickyxie0929
Copy link
Contributor Author

/ok-to-test

Copy link

@rickyxie0929: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests a8d8677 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rickyxie0929 rickyxie0929 removed the request for review from connor-mccarthy July 30, 2024 22:24
@rickyxie0929 rickyxie0929 marked this pull request as ready for review July 30, 2024 22:25
@gregsheremeta
Copy link
Contributor

Could you elaborate in your commit messages and PR description as to what the purpose of this is? "Update pipeline_spec" is a little too generic. Perhaps describe what a Platform Spec is, and give some examples of what kinds of arbitrary configuration would go in the struct. Thanks!

@github-actions github-actions bot added the Stale label Nov 20, 2024
@github-actions github-actions bot closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants