-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scaffold for Yunikorn batch scheduler #2099
Add scaffold for Yunikorn batch scheduler #2099
Conversation
78f6ae2
to
5be9def
Compare
4681c9a
to
d62726c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jacobsalway . This is looks good to me.
It would be great to add some examples, documentation, and unit tests for using YuniKorn with the Spark Operator.
@vara-bonthu I'm happy to put everything under one PR with docs, test etc. but thought it might be easier to split the work into separate PRs under this issue to avoid draft PRs sitting around for a while #2098 |
Hi @jacobsalway , this work is great. I have modified the batch scheduler framework in #2072, and we should release v2.0.0-rc.0 soon, so would you mind rebase your work on this new 2.0 version. |
d62726c
to
86aa92f
Compare
Hey @ChenYi015 once your controller runtime PR is merged to |
86aa92f
to
0dc641b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🛑 Important:
Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!
For guidelines on how to contribute, please review the CONTRIBUTING.md document.
Purpose of this PR
Add an initial scaffold for a Yunikorn batch scheduler implementation. Splitting the PRs so I can incrementally finish work without leaving a mega PR to be reviewed.
Ref #2098
Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes
Will close #2042 once I've got that functionality merged in separate PRs