-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement an upper bound limit to the number of tracked executor #2181
implement an upper bound limit to the number of tracked executor #2181
Conversation
a99e164
to
1346753
Compare
Hey @andreyvelich, @jacobsalway, @mwielgus Could I please have a review on this PR ? |
7de884e
to
475113d
Compare
@ChenYi015 I've done the change you requested :) |
@vara-bonthu I've added the possibility to customize the value in the chart following your comment |
9ba20ef
to
9447c25
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM. Will wait for another approval. |
Signed-off-by: ImpSy <3097030+ImpSy@users.noreply.github.com>
Signed-off-by: ImpSy <3097030+ImpSy@users.noreply.github.com>
9447c25
to
58cbb83
Compare
@vara-bonthu could you re-review this please 🙏 ? |
@ChenYi015 It's been more than a week that you approve the PR, could we merge it now ? |
/lgtm |
Purpose of this PR
In some case executor can enter in a crashlooping state causing the CR to grow out of control
This can have an impact on the entire SparkApplication CR processing reconciliation loop
This can eventually lead to
etcd
errors when we trying to patch / update the CRProposed changes:
Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Submitting apps and tracking driver pods is the highest priority of the spark-operator
1 app going haywire should not hinder the entirety of the cluster
Checklist
Before submitting your PR, please review the following:
Additional Notes
This feature has been live on our fork for the past year -> spotinst#8