Truncate UI service name if over 63 characters #2311
Conversation
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
jacobsalway
force-pushed
the
driver-service-name-truncation
branch
from
60bb78d
to
af3400d
Compare
|
/assign @ChenYi015 @ImpSy |
|
|
||
| // Truncate the name and append a hash to ensure uniqueness while staying below the limit | ||
| hash := fmt.Sprintf("%x", md5.Sum([]byte(preferredName))) | ||
| return fmt.Sprintf("%s-%s-ui-svc", app.Name[:47], hash[:8]) | ||
| } | ||
|
|
||
| func GetDefaultUIIngressName(app *v1beta2.SparkApplication) string { |
There was a problem hiding this comment.
we should do the same for this function
| } | ||
|
|
||
| // Truncate the name and append a hash to ensure uniqueness while staying below the limit | ||
| hash := fmt.Sprintf("%x", md5.Sum([]byte(preferredName))) |
There was a problem hiding this comment.
wdyt about reusing the first 8 character from the submissionID (app.Status.SubmissionID) instead ?
There was a problem hiding this comment.
Not a bad idea either as that's a UUID. Truncating the name and appending its hash was the first approach that came to mind as I've seen it in other systems/software for truncation.
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
jacobsalway
force-pushed
the
driver-service-name-truncation
branch
from
94ba78b
to
4719b0c
Compare
|
Bumping since the comments were addressed. |
|
/lgtm |
|
@ChenYi015 can you approve this ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015, ImpSy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Purpose of this PR
Truncate the UI service name while appending a hash to ensure uniqueness if longer than 63 characters.
Close #2300
Change Category
Checklist