-
Notifications
You must be signed in to change notification settings - Fork 1.4k
added labelselector for sparkapplications to the cache options #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
added labelselector for sparkapplications to the cache options #2646
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@shvartz311: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nabuskey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I think this is a good feature to have since it was supported in v1.
|
|
||
| command.Flags().DurationVar(&driverPodCreationGracePeriod, "driver-pod-creation-grace-period", 10*time.Second, "Grace period after a successful spark-submit when driver pod not found errors will be retried. Useful if the driver pod can take some time to be created.") | ||
|
|
||
| command.Flags().StringVar(&labelSelectorFilter, "label-selector-filter", "", "Label selector to filter SparkApplications.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| command.Flags().StringVar(&labelSelectorFilter, "label-selector-filter", "", "Label selector to filter SparkApplications.") | |
| command.Flags().StringVar(&labelSelectorFilter, "label-selector-filter", "", "Comma-separated label selector to filter resources. Supports key=value, key!=value, key in (val1,val2), and key existence checks.") |
| &corev1.PersistentVolumeClaim{}: {}, | ||
| &corev1.Service{}: {}, | ||
| &v1beta2.SparkApplication{}: {}, | ||
| &v1beta2.SparkApplication{}: filterByObject, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the only type we want to watch?
Purpose of this PR
Proposed changes:
Change Category
Rationale
Checklist
Additional Notes