Skip to content

Conversation

@ChenYi015
Copy link
Member

Purpose of this PR

  • Deprecate Kustomize manifests since it is not maintained for a long time.
  • The alternative and recommended way is to use Helm to manage Spark operator releases.

Proposed changes:

  • Remove Kustomize manifests and stop generating it.
  • Generate CRDs into charts/spark-operator-chart/crds instead of config/crd/bases.
  • Remove Makefile targets detect-crds-drift and update-crd.
  • Update integration test workflow.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chenyi015. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yi Chen <github@chenyicn.net>
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be people using our repo as their Kustomize base. I'd say we put up a deprecation notice first in the next release, then remove them after the release.

@ChenYi015
Copy link
Member Author

Make sense. Will announuce the deprecation of Kutomize manifests in the next release.
/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants