Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more compatible URL concat way #3704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ You can find the [source code for the **Data passing in python components** tuto
The following simple pipeline adds two integers, and then adds another integer to the result to come up with a final sum.

```python
from urllib.parse import urljoin

from kfp import dsl
from kfp import client

Expand All @@ -117,7 +119,7 @@ run = kfp_client.create_run_from_pipeline_func(
'b': 2
},
)
url = f'{endpoint}/#/runs/details/{run.run_id}'
url = urljoin(endpoint, f'/#/runs/details/{run.run_id}')
print(url)
```

Expand Down Expand Up @@ -159,6 +161,8 @@ The above code consists of the following parts:
* In the fourth part, the following lines instantiate a KFP client using the endpoint obtained in [deployment step](#kfp_qs_deployment) and submit the pipeline to the KFP backend with the required pipeline arguments:

```python
from urllib.parse import urljoin

endpoint = '<KFP_ENDPOINT>'
kfp_client = client.Client(host=endpoint)
run = kfp_client.create_run_from_pipeline_func(
Expand All @@ -168,7 +172,7 @@ The above code consists of the following parts:
'b': 2
},
)
url = f'{endpoint}/#/runs/details/{run.run_id}'
url = urljoin(endpoint, f'/#/runs/details/{run.run_id}')
print(url)
```

Expand Down Expand Up @@ -202,6 +206,7 @@ The following ML pipeline creates a dataset, normalizes the features of the data

```python
from typing import List
from urllib.parse import urljoin

from kfp import client
from kfp import dsl
Expand Down Expand Up @@ -311,7 +316,7 @@ run = kfp_client.create_run_from_pipeline_func(
'neighbors': [3, 6, 9]
},
)
url = f'{endpoint}/#/runs/details/{run.run_id}'
url = urljoin(endpoint, f'/#/runs/details/{run.run_id}')
print(url)
```

Expand Down