-
Notifications
You must be signed in to change notification settings - Fork 40
Flatcar optimize network configuration speed on vmware cloud director #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… bootstrap script configures network and add support for templating in unit files Signed-off-by: Kai Fink <kai.fink@yahoo.de>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @4ch3los. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
is this about rendering the whole provision config and sending it as a userdata so that VM can be provisioned right away without fetching its provisioning instructions? |
Ahh no, the provisioning process doesnt get changed, but for flatcar on vcloud director, the network gets configured by the bootstrap service/script https://github.com/kubermatic/operating-system-manager/blob/main/deploy/osps/default/osp-flatcar.yaml#L192 |
Dont wait for network when using flatcar on vmware-cloud-director, as bootstrap script configures network. To achieve this, template support for unit files was added. This reduces bootstrapping time alot, as waiting for network times out currently
What this PR does / why we need it:
Which issue(s) this PR fixes:
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: