Skip to content

Conversation

4ch3los
Copy link
Contributor

@4ch3los 4ch3los commented Jul 2, 2025

Dont wait for network when using flatcar on vmware-cloud-director, as bootstrap script configures network. To achieve this, template support for unit files was added. This reduces bootstrapping time alot, as waiting for network times out currently

What this PR does / why we need it:

Which issue(s) this PR fixes:

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Flatcar Vmware cloud director, bootstrap time improved

Documentation:

NONE

… bootstrap script configures network and add support for templating in unit files

Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 2, 2025
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign soer3n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2025
@kubermatic-bot
Copy link
Contributor

Hi @4ch3los. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2025
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2025
@kron4eg
Copy link
Member

kron4eg commented Oct 1, 2025

is this about rendering the whole provision config and sending it as a userdata so that VM can be provisioned right away without fetching its provisioning instructions?

@4ch3los
Copy link
Contributor Author

4ch3los commented Oct 1, 2025

is this about rendering the whole provision config and sending it as a userdata so that VM can be provisioned right away without fetching its provisioning instructions?

Ahh no, the provisioning process doesnt get changed, but for flatcar on vcloud director, the network gets configured by the bootstrap service/script https://github.com/kubermatic/operating-system-manager/blob/main/deploy/osps/default/osp-flatcar.yaml#L192
But the service units is defined to run after the network is available, which wont happen before it runs, so it waits for the timeout and delays the provisioning by about 2 minutes. This pr adds the ability to template the units with go templating, and removes the wait on the bootstrap.unit for flatcar on vcloud :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants