Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib-external-provisioner to v10.0.1 #1250

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 6, 2024

/kind bug

What this PR does / why we need it:
Update sigs.k8s.io/sig-storage-lib-external-provisioner to the latest release to fix removal of the PV finalizer.

Which issue(s) this PR fixes:

Fixes #1235

Does this PR introduce a user-facing change?:

Fixed removal of PV protection finalizer. PVs are no longer Terminating forever after PVC deletion.

Update sigs.k8s.io/sig-storage-lib-external-provisioner to the latest
release to fix removal of the PV finalizer.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@carlory
Copy link
Member

carlory commented Aug 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 77c715d into kubernetes-csi:master Aug 6, 2024
8 checks passed
jsafrane added a commit to jsafrane/external-provisioner that referenced this pull request Aug 6, 2024
k8s-ci-robot added a commit that referenced this pull request Aug 6, 2024
…-upstream-release-5.0

Manual cherry pick of #1250: Update lib-external-provisioner to v10.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete volume requests are sent twice with new provisioner version v5.0.1
3 participants