-
Notifications
You must be signed in to change notification settings - Fork 36
fix: go module name convention #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.0
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nalum The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @nalum! |
Hi @nalum. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
@nalum: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Looks like there are issues installing go in two of the tests and a failure of Anything I can/need to do to move this along? |
Hmm the download link is missing a ".0" somehow, the correct link should be: https://dl.google.com/go/go1.22.0.linux-amd64.tar.gz |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Update the module name in the
v2
release to follow the Go Module naming convention, see also #225Which issue(s) this PR fixes:
Special notes for your reviewer:
I've created this PR as the version of Go in the
v3
module release is incompatible with CAPI.Does this PR introduce a user-facing change?: