Skip to content

Conversation

nalum
Copy link

@nalum nalum commented Sep 15, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update the module name in the v2 release to follow the Go Module naming convention, see also #225

Which issue(s) this PR fixes:

Special notes for your reviewer:
I've created this PR as the version of Go in the v3 module release is incompatible with CAPI.

Does this PR introduce a user-facing change?:

Fixed the module name so that it can import the v2 module version. You can now import the v2.0 module with 'import "github.com/kubernetes-csi/lib-volume-populator/v2"'

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nalum
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @nalum!

It looks like this is your first PR to kubernetes-csi/lib-volume-populator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/lib-volume-populator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nalum. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2025
@sunnylovestiramisu
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2025
@sunnylovestiramisu sunnylovestiramisu self-assigned this Sep 15, 2025
@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

@nalum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-lib-volume-populator-1-31-on-kubernetes-1-31 dcc1699 link true /test pull-kubernetes-csi-lib-volume-populator-1-31-on-kubernetes-1-31
pull-kubernetes-csi-lib-volume-populator-1-32-on-kubernetes-1-32 dcc1699 link true /test pull-kubernetes-csi-lib-volume-populator-1-32-on-kubernetes-1-32
pull-kubernetes-csi-lib-volume-populator-1-33-on-kubernetes-1-33 dcc1699 link false /test pull-kubernetes-csi-lib-volume-populator-1-33-on-kubernetes-1-33

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nalum
Copy link
Author

nalum commented Sep 16, 2025

Looks like there are issues installing go in two of the tests and a failure of [It] Identity Service GetPluginCapabilities should return appropriate capabilities.

Anything I can/need to do to move this along?

@sunnylovestiramisu
Copy link
Contributor

Hmm the download link is missing a ".0" somehow, the correct link should be: https://dl.google.com/go/go1.22.0.linux-amd64.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants