fix: Re-add cluster label to KubeStatefulSetUpdateNotRolledOut #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert
KubeStatefulSetUpdateNotRolledOut
was modified by the following PR:The aggregation labels were changed and several were removed when refactoring from
without
toby
:job
cluster
instance
I think the
instance
label is probably not useful, butjob
andcluster
are certainly useful, so this PR proposes to bring them back.Here are all the labels from the previous
without
version of the alert expression (my alert wasn't firing so I commented out the irrelevant parts of the PromQL just to see the underlying labels):Here is a test of the alert rule generated by this PR, which shows the
job
andcluster
labels still intact whilst maintaining use of theby
aggregation as suggested by thepint
tool: