Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add cluster label to KubeStatefulSetUpdateNotRolledOut #967

Conversation

skl
Copy link
Collaborator

@skl skl commented Aug 28, 2024

The alert KubeStatefulSetUpdateNotRolledOut was modified by the following PR:

The aggregation labels were changed and several were removed when refactoring from without to by:

  • job
  • cluster
  • instance

I think the instance label is probably not useful, but job and cluster are certainly useful, so this PR proposes to bring them back.

Here are all the labels from the previous without version of the alert expression (my alert wasn't firing so I commented out the irrelevant parts of the PromQL just to see the underlying labels):

Screenshot 2024-08-28 at 14 20 01

Here is a test of the alert rule generated by this PR, which shows the job and cluster labels still intact whilst maintaining use of the by aggregation as suggested by the pint tool:

Screenshot 2024-08-28 at 14 20 33

@povilasv povilasv merged commit 37dcc12 into kubernetes-monitoring:master Sep 3, 2024
9 checks passed
@skl skl deleted the skl/KubeStatefulSetUpdateNotRolledOut-cluster-label branch September 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants