Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated golangci-lint flag. #668

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove deprecated golangci-lint flag. #668

merged 1 commit into from
Oct 16, 2024

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Oct 16, 2024

After this change we still ignore vendor. Newer versions have --exclude-dirs-use-default which defaults to true.

@jkh52
Remove deprecated golangci-lint flag.
be3ffb3 
After this change we still ignore vendor. Newer versions have --exclude-dirs-use-default which defaults to true.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@cheftako
Copy link
Contributor

Looks like we are still running pull-apiserver-network-proxy-make-lint-master.

@jkh52
Copy link
Contributor Author

jkh52 commented Oct 16, 2024

pull-apiserver-network-proxy-make-lint-master

Yeah I saw that. Maybe there is some 'test-infra' release that has to happen? But - I believe other recent similar PRs were merged on /lgtm.

@cheftako
Copy link
Contributor

pull-apiserver-network-proxy-make-lint-master

Yeah I saw that. Maybe there is some 'test-infra' release that has to happen? But - I believe other recent similar PRs were merged on /lgtm.

I think I found and fixed the issue.

@cheftako
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 14f752e into kubernetes-sigs:master Oct 16, 2024
22 checks passed
@jkh52
Copy link
Contributor Author

jkh52 commented Oct 16, 2024

pull-apiserver-network-proxy-make-lint-master

Yeah I saw that. Maybe there is some 'test-infra' release that has to happen? But - I believe other recent similar PRs were merged on /lgtm.

I think I found and fixed the issue.

What was the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkh52 @cheftako @k8s-ci-robot